brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ygy <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-137 stopIptables and ope...
Date Tue, 23 Jun 2015 11:09:12 GMT
Github user ygy commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/707#discussion_r33030496
  
    --- Diff: utils/common/src/main/java/brooklyn/util/ssh/IptablesCommands.java ---
    @@ -89,6 +89,38 @@ public static String iptablesServiceStatus() {
             return iptablesService("status");
         }
     
    +    @Beta // implementation not portable across distros
    +    public static String firewalldService(String cmd) {
    +        return sudo(alternatives(
    +                BashCommands.ifExecutableElse1("systemctl", "systemctl " + cmd + " firewalld"),
    +                "/usr/bin/systemctl " + cmd + " firewalld"));
    --- End diff --
    
    It's just as a precaution in case someone changed or removed environment variables for
non-interactive shells


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message