brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Catalog default niceness
Date Mon, 22 Jun 2015 23:24:01 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/705#discussion_r32995565
  
    --- Diff: core/src/main/java/brooklyn/enricher/basic/AbstractAggregator.java ---
    @@ -187,6 +187,24 @@ protected void setEntityAfterSubscribingProducerChildrenEvents()
{
             }
         }
     
    +    /** true if this should aggregate members */
    +    protected boolean isAggregatingMembers() {
    +        if (Boolean.TRUE.equals(fromMembers)) return true;
    --- End diff --
    
    remind me: is setEntity(EntityLocal) called on rebind? OR could `fromMembers` potentially
be null after rebeind?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message