brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ygy <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-137 stopIptables and ope...
Date Mon, 22 Jun 2015 13:53:20 GMT
Github user ygy commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/707#discussion_r32935680
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -365,6 +365,16 @@ public boolean isWindows(NodeMetadata node, ConfigBag config) {
                     : (OsFamily.WINDOWS == confFamily);
         }
     
    +    public boolean isLocationFirewalldEnabled(SshMachineLocation location) {
    +        int result = location.execCommands("checking if firewalld is active", 
    +                ImmutableList.of(IptablesCommands.firewalldServiceIsActive()));
    +        if (result == 0) {
    +            return true;
    +        }
    +        
    --- End diff --
    
    @neykov here is addressed your previous comment regarding the firewall-cmd existence 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message