brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Wildfly 8 Support (Partial)
Date Fri, 19 Jun 2015 21:46:34 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/621#issuecomment-113652109
  
    Thanks @mikezaccardo - looking good. A few minor comments, some of which should be addressed
and many of which should be deferred.
    
    You said in the description that the live tests "will not yet pass due to the missing
metrics". Given we'll not get those metrics out of Wildfly in the short term, is there something
we should do to get the live tests passing? For example, parameterise the `doTest()` method
to say whether to assert the attributes have been set?
    
    Would be good to have some tests that pass, so we can regression test this after it's
been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message