brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix integration tests (core and s...
Date Fri, 19 Jun 2015 20:29:49 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/700#discussion_r32866496
  
    --- Diff: software/base/src/test/java/brooklyn/entity/basic/lifecycle/StartStopSshDriverTest.java
---
    @@ -113,10 +116,10 @@ public void testExecuteDoesNotLeaveRunningStreamGobblerThread()
{
                 @Override
                 public void run() {
                   List<ThreadInfo> currentThreads = getThreadsCalling(StreamGobbler.class);
    -              List<Long> currentThreadIds = getThreadId(currentThreads);
    +              Collection<Long> currentThreadIds = MutableSet.copyOf(getThreadId(currentThreads));
    --- End diff --
    
    Personal preference to declare as `Set<Long>`, given line 122 will compare it with
a set.
    
    But that's really minor, given that 3 lines earlier we can see it being instantiated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message