brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix integration tests (core and s...
Date Fri, 19 Jun 2015 20:25:44 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/700#discussion_r32866045
  
    --- Diff: core/src/test/java/brooklyn/location/geo/HostGeoLookupIntegrationTest.java ---
    @@ -34,6 +35,7 @@
     
         public static final Logger log = LoggerFactory.getLogger(HostGeoLookupIntegrationTest.class);
         
    +    // Needs fast network connectivity to figure out the external IP. If response not
returned in 2s fails.
    --- End diff --
    
    Interesting. Longer term do you think it's right to fail? Is it possible to differentiate
between "still waiting" and failed? Could we wait longer? Or could we throw `SkipException`
if we know that it's not a true failure?
    
    Certainly happy with as-is for this release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message