brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix integration tests (core and s...
Date Fri, 19 Jun 2015 20:21:26 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/700#discussion_r32865690
  
    --- Diff: core/src/test/java/brooklyn/event/feed/http/HttpFeedTest.java ---
    @@ -300,24 +300,11 @@ public void testStartSuspended() throws Exception {
         }
     
     
    -    @Test(groups="Integration")
    -    /** marked as integration so it doesn't fail the plain build in environments
    -     * with dodgy DNS (ie where "unresolvable_hostname_or_one_with_no_webserver_on_port_80"
resolves as a host run by the provider)
    -     * <p>
    -     * (a surprising number of ISP's do this,
    -     * happily serving adverts for your ISP, yielding "success" here,
    -     * or timing out, giving null here)
    -     * <p>
    -     * if you want to make this test work, you can e.g. set it to loopback IP assuming
you don't have any servers on port 80,
    -     * with the following in /etc/hosts
    -     * <p>  
    -     * 127.0.0.1  unresolvable_hostname_or_one_with_no_webserver_on_port_80
    -    // or some other IP which won't resolve
    -     */
    +    @Test
         public void testPollsAndParsesHttpErrorResponseWild() throws Exception {
             feed = HttpFeed.builder()
                     .entity(entity)
    -                .baseUri("http://unresolvable_hostname_or_one_with_no_webserver_on_port_80")
    +                .baseUri("http://0.0.0.0")
    --- End diff --
    
    Nice!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message