brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Fix integration tests (core and s...
Date Fri, 19 Jun 2015 20:07:26 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/location/basic/ ---
    @@ -876,7 +877,8 @@ public boolean isSshable() {
             String cmd = "date";
             try {
                 try {
    -                Socket s = new Socket(getAddress(), getPort());
    +                Socket s = new Socket();
    +                s.connect(new InetSocketAddress(getAddress(), getPort()), SSHABLE_CONNECT_TIMEOUT);
    --- End diff --
    Makes sense. Could overload `isSshable()` to allow a custom timeout to be passed in, but
not sure where we'd make use of that. So happy to stick with your change.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message