brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix integration tests (core and s...
Date Fri, 19 Jun 2015 15:37:54 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/700#discussion_r32840547
  
    --- Diff: core/src/main/java/brooklyn/util/internal/ssh/ShellAbstractTool.java ---
    @@ -296,9 +296,10 @@ public ToolAbstractAsyncExecScript(Map<String,?> props) {
              * The executed command will return immediately, but the output from the script
              * will continue to be written 
              * note that some modes require \$RESULT passed in order to access a variable,
whereas most just need $ */
    +        @Override
             protected List<String> buildRunScriptCommand() {
                 String touchCmd = String.format("touch %s %s %s %s", stdoutPath, stderrPath,
exitStatusPath, pidPath);
    -            String cmd = String.format("( %s > %s 2> %s < /dev/null ; echo $?
> %s ) & disown", scriptPath, stdoutPath, stderrPath, exitStatusPath);
    --- End diff --
    
    This command was working fine with the tests, but using `disown` while ending the ssh
session doesn't seem right, so I converted it to use `nohup`. Any reason it shouldn't be changed?
cc @aledsage 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message