brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Determine type of entity in rest ...
Date Fri, 19 Jun 2015 12:15:14 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/690#discussion_r32823340
  
    --- Diff: usage/rest-client/pom.xml ---
    @@ -114,14 +114,14 @@
                 <groupId>org.apache.brooklyn</groupId>
                 <artifactId>brooklyn-core</artifactId>
                 <version>${project.version}</version>
    +            <classifier>tests</classifier>
                 <scope>test</scope>
             </dependency>
             <dependency>
                 <groupId>org.apache.brooklyn</groupId>
                 <artifactId>brooklyn-core</artifactId>
                 <version>${project.version}</version>
    -            <classifier>tests</classifier>
    -            <scope>test</scope>
    +            <scope>compile</scope>
    --- End diff --
    
    why do we need to add `<scope>compile</scope>`?
    
    previously both dependencies, regular and `<classifier>tests</classifier>`
were only brought in for `test` scope I think which lowers the footprint for someone using
the REST client.  also the ordering of the regular classifier first is cleaner i think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message