brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikezaccardo <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix GeoscalingWebClient create pr...
Date Thu, 18 Jun 2015 22:01:51 GMT
Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/697#discussion_r32783805
  
    --- Diff: software/webapp/src/test/java/brooklyn/entity/dns/geoscaling/GeoscalingWebClientTest.java
---
    @@ -42,8 +42,8 @@
         
         private final static String USERNAME = "cloudsoft";
         private final static String PASSWORD = "cl0uds0ft";
    -    private final static String PRIMARY_DOMAIN = "domain"+((int)(Math.random()*10000))+".test.org";
    -    private final static String SUBDOMAIN = "subdomain"+((int)(Math.random()*10000));
    +    private final static String PRIMARY_DOMAIN = "domain"+((int)(Math.random()*10000)
+ 10000)+".test.org";
    +    private final static String SUBDOMAIN = "subdomain"+((int)(Math.random()*10000) +
10000);
    --- End diff --
    
    To guarantee that they don't collide with the existing domains (as unlikely as it is).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message