brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ygy <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Riak uses ulimit configuration re...
Date Tue, 16 Jun 2015 08:50:21 GMT
Github user ygy commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/691#discussion_r32501629
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
---
    @@ -594,4 +595,16 @@ private void addRiakOnPath(ScriptHelper scriptHelper) {
     //        log.warn("riak command not found on PATH. Altering future commands' environment
variables from {} to {}", getShellEnvironment(), newPathVariable);
             scriptHelper.environmentVariablesReset(newPathVariable);
         }
    +
    +    @Override
    +    public Integer getNumberOfOpenFiles() {
    +        Integer defaultNumberOfFiles = RiakNode.RIAK_NUM_OPEN_FILES.getConfigKey().getDefaultValue();
    +        Integer numberOfFiles = entity.getConfig(RiakNode.RIAK_NUM_OPEN_FILES);
    +        if (numberOfFiles.compareTo(defaultNumberOfFiles) < 0) {
    +            log.warn("Specified number of open files : {} : less than the required minimum.
Using defaults : {}.", numberOfFiles, defaultNumberOfFiles);
    +            entity.setAttribute(RiakNode.RIAK_NUM_OPEN_FILES, defaultNumberOfFiles);
    --- End diff --
    
    Completely agree. It would be better to notify the user and stop the installation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message