brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Riak uses ulimit configuration re...
Date Mon, 15 Jun 2015 21:12:16 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/691#discussion_r32467435
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNode.java ---
    @@ -72,7 +72,12 @@
     
         ConfigKey<String> RIAK_CONF_ADDITIONAL_CONTENT = ConfigKeys.newStringConfigKey(
                 "riak.riakConf.additionalContent", "Template file (in freemarker format)
for setting up additional settings in the riak.conf file", "");
    -
    +    
    +    // numberOpenFiles' default value (65536) is based on the Basho's recommendation
- http://docs.basho.com/riak/latest/ops/tuning/open-files-limit/ 
    +    @SetFromFlag("numberOpenFiles")
    --- End diff --
    
    Better name it **max**OpenFiles? Setting this will change the limit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message