brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Provision latch
Date Thu, 11 Jun 2015 14:38:38 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/681#discussion_r32227208
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
    @@ -143,6 +143,7 @@
          * component is up, but this entity does not care about the dependent component's
actual config values.
          */
     
    +    public static final ConfigKey<Boolean> PROVISION_LATCH = newBooleanConfigKey("provision.latch",
"Latch for blocking location provision until ready");
    --- End diff --
    
    `SoftwareProcess` redefines the other lifecycle latches (referencing the ones here in
`BrooklynConfigKeys`); should `PROVISION_LATCH` also be aliased there for easier discovery?
I'm not convinced this is necessarily a good pattern, but inconsistency is worse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message