brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikezaccardo <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-149: Partial fix for reb...
Date Mon, 08 Jun 2015 15:12:00 GMT
Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/683#discussion_r31924382
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/persister/BrooklynMementoPersisterToObjectStore.java
---
    @@ -174,11 +176,23 @@ public BrooklynMementoPersisterToObjectStore(PersistenceObjectStore
objectStore,
             if (item==null || item.getCatalogItemId()==null) {
                 return null;
             }
    -        CatalogItem<?, ?> catalogItem = CatalogUtils.getCatalogItemOptionalVersion(lookupContext.lookupManagementContext(),
item.getCatalogItemId());
    +        // See RebindIteration.BrooklynObjectInstantiator.load(), for handling where
catalog item is missing;
    +        // similar logic here.
    +        String catalogItemId = item.getCatalogItemId();
    +        CatalogItem<?, ?> catalogItem = CatalogUtils.getCatalogItemOptionalVersion(lookupContext.lookupManagementContext(),
catalogItemId);
    +        if (catalogItem == null && BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_INFER_CATALOG_ITEM_ON_REBIND))
{
    --- End diff --
    
    Same `if` structure comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message