brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Fix tests on Windows
Date Wed, 03 Jun 2015 16:24:36 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/entity/rebind/ ---
    @@ -278,7 +278,9 @@ public void waitForPendingComplete(Duration timeout, boolean canTrigger)
                     while (writeCount.get() <= targetWriteCount) {
                         Duration left = timer.getDurationRemaining();
                         if (left.isPositive()) {
    -                        writeCount.wait(left.lowerBound(Duration.millis(10)).toMilliseconds());
    +                        synchronized(writeCount) {
    +                            writeCount.wait(left.lowerBound(Duration.millis(10)).toMilliseconds());
    --- End diff --
    wow, that was a bad bug to sneak in! Thanks for fixing!

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message