brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Remove shared statics causing iss...
Date Tue, 02 Jun 2015 23:25:45 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/671#discussion_r31581556
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -204,7 +205,8 @@
         private static final Pattern LIST_PATTERN = Pattern.compile("^\\[(.*)\\]$");
         private static final Pattern INTEGER_PATTERN = Pattern.compile("^\\d*$");
     
    -    private static boolean loggedSshKeysHint = false;
    +    private final AtomicBoolean loggedSshKeysHint = new AtomicBoolean(false);
    +    private final AtomicBoolean listedAvailableTemplatesOnNoSuchTemplate = new AtomicBoolean(false);
    --- End diff --
    
    a guava `Cache` is maybe the hyper-engineered way but i think tying it to the `JcloudsLocation`
instance is a pragmatic step.  the `JcloudsLocation` instance should be cached, i *think*,
and if not all we do is log some debug/info a bit more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message