Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
Date: Fri, 15 May 2015 13:10:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@brooklyn.incubator.apache.org
Message-ID: <JIRA.12829395.1431475038000.126451.1431695401468@Atlassian.JIRA>
In-Reply-To: <JIRA.12829395.1431475038000@Atlassian.JIRA>
References: <JIRA.12829395.1431475038000@Atlassian.JIRA>
 <JIRA.12829395.1431475038001@arcas>
Subject: [jira] [Commented] (BROOKLYN-143) Add support for Hazelcast
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/BROOKLYN-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545458#comment-14545458 ] 

ASF GitHub Bot commented on BROOKLYN-143:
-----------------------------------------

Github user ygy commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/642#discussion_r30406354
  
    --- Diff: sandbox/nosql/src/main/java/brooklyn/entity/nosql/hazelcast/HazelcastNode.java ---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.entity.nosql.hazelcast;
    +
    +import brooklyn.catalog.Catalog;
    +import brooklyn.config.ConfigKey;
    +import brooklyn.entity.basic.ConfigKeys;
    +import brooklyn.entity.basic.SoftwareProcess;
    +import brooklyn.entity.java.UsesJava;
    +import brooklyn.entity.java.UsesJmx;
    +import brooklyn.entity.proxying.ImplementedBy;
    +import brooklyn.event.basic.BasicAttributeSensorAndConfigKey;
    +import brooklyn.event.basic.BasicAttributeSensorAndConfigKey.StringAttributeSensorAndConfigKey;
    +import brooklyn.util.flags.SetFromFlag;
    +import brooklyn.util.javalang.JavaClassNames;
    +
    +/**
    + * An {@link brooklyn.entity.Entity} that represents an Hazelcast node
    + */
    +@Catalog(name="Hazelcast Node", description="Hazelcast is a clustering and highly scalable data distribution platform for Java.")
    +
    +@ImplementedBy(HazelcastNodeImpl.class)
    +public interface HazelcastNode extends SoftwareProcess, UsesJava, UsesJmx {
    +    @SetFromFlag("version")
    +    ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION, "3.4.2");
    +    
    +    @SetFromFlag("downloadUrl")
    +    BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new BasicAttributeSensorAndConfigKey<String>(
    +            SoftwareProcess.DOWNLOAD_URL, "https://repo1.maven.org/maven2/com/hazelcast/hazelcast/${version}/hazelcast-${version}.jar");
    +    
    +    @SetFromFlag("configFileUrl")
    +    ConfigKey<String> TEMPLATE_CONFIGURATION_URL = ConfigKeys.newStringConfigKey(
    +            "hazelcast.node.template.configuration.url", "Template file (in freemarker format) for the hazelcast.xml file", 
    +            JavaClassNames.resolveClasspathUrl(HazelcastNode.class, "hazelcast-brooklyn.xml"));
    +
    +    @SetFromFlag("nodeName")
    +    StringAttributeSensorAndConfigKey NODE_NAME = new StringAttributeSensorAndConfigKey("hazelcast.node.name", 
    +            "Node name (or randomly selected if not set", null);
    +    
    +    @SetFromFlag("clusterName")
    +    StringAttributeSensorAndConfigKey CLUSTER_NAME = new StringAttributeSensorAndConfigKey("hazelcast.node.cluster.name", 
    +            "Cluster name", null);
    --- End diff --
    
    Thanks for the remark.
    
    A single JVM can run multiple Hazelcast instances. They are specified in the ```<group>``` element of the configuration file.
    ```hazelcast.node.cluster.name``` was intended to be used as ```<name>``` value in the ```<group>``` element.
    Often group and cluster names names are identical.
    
    Indeed, current constant's name may lead to inconsistency. I will rename it and properly document the new one.


> Add support for Hazelcast
> -------------------------
>
>                 Key: BROOKLYN-143
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-143
>             Project: Brooklyn
>          Issue Type: New Feature
>            Reporter: Yavor Yanchev
>            Priority: Minor
>
> Hazelcast is a clustering and highly scalable data distribution platform for Java.
> Some of the features it provides
> Distributed java.util.{Queue, Set, List, Map}
> Distributed java.util.concurrency.locks.Lock
> Distributed java.util.concurrent.ExecutorService
> Distributed Indexing and Query support


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)