Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-650-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-650-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Support for deployment to
 Windows
Content-Type: text/plain
Message-Id: <20150520091256.CF137DFB90@git1-us-west.apache.org>
Date: Wed, 20 May 2015 09:12:56 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30683180
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -635,10 +645,12 @@ protected JcloudsSshMachineLocation obtainOnce(ConfigBag setup) throws NoMachine
                     sshHostAndPortOverride = Optional.absent();
                 }
     
    -            if (waitForSshable && skipJcloudsSshing) {
    +            if (waitForSshable && skipJcloudsSshing && !windows) {
                     // once that host:port is definitely reachable, we can create the user
                     waitForReachable(computeService, node, sshHostAndPortOverride, node.getCredentials(), setup);
                     userCredentials = createUser(computeService, node, sshHostAndPortOverride, setup);
    +            } else if (windows) {
    --- End diff --
    
    We want to be able to defer/never waitForWinRmAvailable. That was intent of `waitForSshable` - to turn that off. 
    
    Historically, reason for that was to let the caller set up port forwarding. However, that is now covered in code above (but not for windows case!). So we generally don't make use of the `waitForSshable` much these days. But given it's there...
    
    I wonder if we should generalise it to a "waitForReachable" or some such.
    
    Don't worry about it for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---