Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-617-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-617-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: CLI commands for
 manipulating cat...
Content-Type: text/plain
Message-Id: <20150519113535.0F959DFFF0@git1-us-west.apache.org>
Date: Tue, 19 May 2015 11:35:35 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30590479
  
    --- Diff: utils/common/src/main/java/brooklyn/util/javalang/Threads.java ---
    @@ -44,7 +46,15 @@ public static boolean removeShutdownHook(Thread hook) {
                 return Runtime.getRuntime().removeShutdownHook(hook);
             } catch (IllegalStateException e) {
                 // probably shutdown in progress
    -            log.debug("cannot remove shutdown hook "+hook+": "+e);
    +            String text = Exceptions.collapseText(e);
    +            if (text.contains("Shutdown in progress")) {
    +                if (log.isTraceEnabled()) {
    +                    log.trace("Could not remove shutdown hook "+hook+": "+text);
    --- End diff --
    
    Add trace and debug level, we should just include the entire stacktrace rather than truncating. Otherwise we risk losing important information for debugging problems that customers send via log files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---