Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-630-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-630-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: jclouds location customizer
 suppo...
Content-Type: text/plain
Message-Id: <20150508055743.49529E4422@git1-us-west.apache.org>
Date: Fri,  8 May 2015 05:57:43 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/630#discussion_r29918457
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -1764,24 +1769,57 @@ public void release(SshMachineLocation machine) {
             LOG.info("Releasing machine {} in {}, instance id {}", new Object[] {machine, this, instanceId});
     
             Exception tothrow = null;
    +
    +        if (machine instanceof JcloudsSshMachineLocation) {
    +            ConfigBag setup = config().getBag();
    +            for (JcloudsLocationCustomizer customizer : getCustomizers(setup)) {
    +                try {
    +                    customizer.preRelease((JcloudsSshMachineLocation) machine);
    +                } catch (Exception e) {
    +                    LOG.error("Problem invoking pre-release customizer "+customizer+" for machine "+machine+" in "+this+", instance id "+instanceId+
    --- End diff --
    
    Or is the code trying to release aggressively and throwing here will lead to machine leaks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---