Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
Received-SPF: error (athena.apache.org: local policy)
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-624-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-624-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Don't fail on startup in
 case of ...
Content-Type: text/plain
Message-Id: <20150505153056.4B2B3E0FE2@git1-us-west.apache.org>
Date: Tue,  5 May 2015 15:30:56 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/624#discussion_r29680075
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/SoftwareProcessImpl.java ---
    @@ -494,17 +494,24 @@ public void waitForEntityStart() {
             CountdownTimer timer = startTimeout.countdownTimer();
             boolean isRunningResult = false;
             long delay = 100;
    +        Exception firstFailure = null;
             while (!isRunningResult && !timer.isExpired()) {
                 Time.sleep(delay);
                 try {
                     isRunningResult = driver.isRunning();
    +                if (log.isDebugEnabled()) log.debug("checked {}, 'is running' returned: {}", this, isRunningResult);
                 } catch (Exception  e) {
    -                ServiceStateLogic.setExpectedState(this, Lifecycle.ON_FIRE);
    --- End diff --
    
    I'd like to treat exceptions from `isRunning` analogously to returning false. This means setting the expected state to `RUNNING` and the actual state (coming from the enrichers) to 'ON-FIRE' (because of the failing check).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---