brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix Jenkins build error - "Unable...
Date Fri, 29 May 2015 11:50:50 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/667

    Fix Jenkins build error - "Unable to access URL brooklyn.webconsole.security.keystore.url"

    Fix transformation of URL to file path - a good example why one shouldn't use string operations
when converting between file path and URL.
    Sample failure - https://builds.apache.org/job/incubator-brooklyn-pull-requests/1267/console
    
    ```
    erifyHttps(brooklyn.launcher.BrooklynWebServerTest)  Time elapsed: 0.018 sec  <<<
FAILURE!
    java.lang.IllegalArgumentException: Unable to access URL brooklyn.webconsole.security.keystore.url:
/home/jenkins/jenkins-slave/workspace/incubator-brooklyn-pull-requests%402/usage/launcher/target/test-classes/server.ks
    	at brooklyn.util.ResourceUtils.getResourceFromUrl(ResourceUtils.java:287)
    	at brooklyn.util.ResourceUtils.checkUrlExists(ResourceUtils.java:484)
    	at brooklyn.launcher.BrooklynWebServer.getLocalKeyStorePath(BrooklynWebServer.java:515)
    	at brooklyn.launcher.BrooklynWebServer.createContextFactory(BrooklynWebServer.java:443)
    	at brooklyn.launcher.BrooklynWebServer.start(BrooklynWebServer.java:373)
    	at brooklyn.launcher.BrooklynWebServerTest.verifyHttps(BrooklynWebServerTest.java:115)
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/invalid-file-from-url

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #667
    
----
commit 6a466b892be63e22c92fba5b5cc62764a008ef6d
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2015-05-29T11:41:49Z

    Fix transformation of URL to file path

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message