brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Jclouds location resolver
Date Fri, 29 May 2015 13:38:04 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/655#discussion_r31324402
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocationResolver.java
---
    @@ -50,10 +50,10 @@
     
         public static final Logger log = LoggerFactory.getLogger(JcloudsLocationResolver.class);
         
    -    public static final String JCLOUDS = "jclouds";
    +    private static final String JCLOUDS = "jclouds";
         
    -    public static final Map<String,ProviderMetadata> PROVIDERS = getProvidersMap();
    -    public static final Map<String,ApiMetadata> APIS = getApisMap();
    +    private static final Map<String,ProviderMetadata> PROVIDERS = getProvidersMap();
    +    private static final Map<String,ApiMetadata> APIS = getApisMap();
    --- End diff --
    
    I don't see much reason for them to be public. Protected would make more sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message