brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Jclouds location resolver
Date Fri, 29 May 2015 13:37:18 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/655#discussion_r31324334
  
    --- Diff: locations/jclouds/src/test/java/brooklyn/location/jclouds/BrooklynMachinePoolLiveTest.java
---
    @@ -98,6 +98,6 @@ public void buildClaimAndDestroy() {
         
     
         private JcloudsLocation resolve(String spec) {
    -        return (JcloudsLocation) managementContext.getLocationRegistry().resolve(JcloudsLocationResolver.JCLOUDS+":"+spec);
    +        return (JcloudsLocation) managementContext.getLocationRegistry().resolve("jclouds:"+spec);
    --- End diff --
    
    There are so many classes that hardcode "jclouds:..." that I think it's a minor one, but
I'll switch it for `new JcloudsLocationResolver().getPrefix()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message