brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Jclouds location resolver
Date Thu, 28 May 2015 12:01:56 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/655#discussion_r31225820
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -1540,6 +1540,58 @@ public JcloudsSshMachineLocation rebindMachine(Map<?,?> flags,
NodeMetadata meta
         }
     
         /**
    +     * @return a predicate that returns true if a {@link ComputeMetadata} instance is
suitable for
    +     *      rebinding to given the configuration in {@link ConfigBag config}.
    +     */
    +    protected Predicate<ComputeMetadata> getComputeMetadataPredicate(ConfigBag
config) {
    +        final String rawId = (String) config.getStringKey("id");
    +        final String rawHostname = (String) config.getStringKey("hostname");
    +        final String rawRegion = (String) config.getStringKey("region");
    +        return new Predicate<ComputeMetadata>() {
    --- End diff --
    
    if this would ever be used in config then we should avoid anonymous classes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message