brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Fri, 22 May 2015 13:35:49 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30894902
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/SoftwareProcessImpl.java ---
    @@ -442,11 +442,12 @@ protected final void callStartHooks() {}
          * plus any ports defined with a config keys ending in .port 
          */
         protected Collection<Integer> getRequiredOpenPorts() {
    -        Set<Integer> ports = MutableSet.of(22);
    +        // TODO: Should only open 22 *or* 5985. Perhaps a flag / ConfigKey on SoftwareProcessImpl?
    +        Set<Integer> ports = MutableSet.of(22, 5985, 3389);
    --- End diff --
    
    3389 is RDP; 5985 is WinRM
    3389 isn't used by Brooklyn, but useful for the end-user subsequently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message