brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: add support to control java versi...
Date Fri, 22 May 2015 09:55:43 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/619#discussion_r30882748
  
    --- Diff: software/base/src/main/java/brooklyn/entity/java/JavaSoftwareProcessSshDriver.java
---
    @@ -360,7 +316,7 @@ protected int tryJavaInstall(String version, String command) {
          * Checks for the version of Java installed on the entity's location over SSH.
          * @return An Optional containing the version portion of `java -version`, or absent
if no Java found.
          */
    -    protected Optional<String> getCurrentJavaVersion() {
    +    protected Optional<String> getInstalledJavaVersion() {
    --- End diff --
    
    @andreaturli strongly agree, this class is often subclassed so let's ensure we maintain
api compatibility even on protected methods.  apart from this good to merge in my view.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message