brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Thu, 21 May 2015 15:28:58 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30813782
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/PeriodicDeltaChangeListener.java ---
    @@ -348,13 +336,40 @@ private void addReferencedObjects(DeltaCollector deltaCollector)
{
         }
         
         @VisibleForTesting
    -    public void persistNow() {
    -        if (!isActive()) {
    +    public boolean persistNowSafely(boolean alreadyHasMutex) {
    --- End diff --
    
    Since the mutex is private it makes sense to expose to the outside only with alreadyHasMutex=false
(i.e. a separate public metod which passes false), but not important.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message