brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Wed, 20 May 2015 14:32:29 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30707762
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -1729,6 +1876,27 @@ protected JcloudsSshMachineLocation createJcloudsSshMachineLocation(ComputeServi
             }
         }
     
    +    protected WinRmMachineLocation registerWinRmMachineLocation(String vmHostname, ConfigBag
setup, String nodeId) {
    +        WinRmMachineLocation winRmMachineLocation = createWinRmMachineLocation(vmHostname,
setup);
    +        winRmMachineLocation.setParent(this);
    --- End diff --
    
    I wonder why we don't set the parent inside `registerJcloudsSshMachineLocation`. Ignore
this comment for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message