brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Wed, 20 May 2015 13:39:55 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30701852
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -597,7 +612,22 @@ private void collectCatalogItems(String sourceYaml, Map<?,?>
itemMetadata, List<
             Collection<CatalogBundle> libraryBundles = CatalogItemDtoAbstract.parseLibraries(librariesCombined);
     
             // TODO as this may take a while if downloading, the REST call should be async
    +        // (this load is required for the scan below and I think also for yaml resolution)
             CatalogUtils.installLibraries(mgmt, libraryBundlesNew);
    +
    +        Boolean scanJavaAnnotations = getFirstAs(itemMetadata, Boolean.class, "scanJavaAnnotations",
"scan_java_annotations").orNull();
    +        if (scanJavaAnnotations==null || !scanJavaAnnotations) {
    +            // don't scan
    +        } else {
    +            // scan for annotations: if libraries here, scan them; if inherited libraries
error; else scan classpath
    +            if (!libraryBundlesNew.isEmpty()) {
    +                result.addAll(scanAnnotationsFromBundles(mgmt, libraryBundlesNew));
    +            } else if (libraryBundles.isEmpty()) {
    +                result.addAll(scanAnnotationsFromLocal(mgmt));
    +            } else {
    +                throw new IllegalStateException("Cannot scan catalog node no local bundles,
and with inherited bundles we will not scan the classpath");
    +            }
    --- End diff --
    
    personally i'd rather keep the yaml tight.  and do away with local classpath autoscan
altogether.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message