brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Wed, 20 May 2015 10:19:15 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30687606
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -1071,15 +1195,32 @@ public boolean apply(@Nullable Method input) {
                                       // can coerce to
                                       if (input == null) return false;
                                       if (!input.getName().equals(option.getKey())) return
false;
    +                                  int numOptionParams = option.getValue() instanceof
List ? ((List)option.getValue()).size() : 1;
                                       Type[] parameterTypes = input.getGenericParameterTypes();
    -                                  return parameterTypes.length == 1
    -                                          && TypeCoercions.tryCoerce(option.getValue(),
TypeToken.of(parameterTypes[0])).isPresentAndNonNull();
    +                                  if (parameterTypes.length != numOptionParams) return
false;
    --- End diff --
    
    This looks familiar for another PR (https://github.com/apache/incubator-brooklyn/pull/639)
- will assume that is going to be reviewed+merged first, and this PR rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message