brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Wed, 20 May 2015 10:17:47 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30687518
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -938,7 +1058,11 @@ public void apply(TemplateOptions t, ConfigBag props, Object v)
{
                         public void apply(TemplateOptions t, ConfigBag props, Object v) {
                             if (t instanceof EC2TemplateOptions) {
                                 if (v==null) return;
    -                            ((EC2TemplateOptions)t).userData(v.toString().getBytes());
    +                            String data = v.toString();
    +                            if (!(data.startsWith("<script>") || data.startsWith("<powershell>")))
{
    +                                data = "<script> " + data + " </script>";
    --- End diff --
    
    Do we have a test that this works for linux and for windows? (haven't reached your tests
in the PR review yet).
    
    Out of interest, where in jclouds is this documented?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message