brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Wed, 20 May 2015 10:14:10 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30687294
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -836,6 +910,52 @@ protected JcloudsSshMachineLocation obtainOnce(ConfigBag setup) throws
NoMachine
             }
         }
     
    +    private void waitForWinRmAvailable(final NodeMetadata node, final LoginCredentials
expectedCredentials, ConfigBag setup) {
    +        // TODO: Reduce / remove duplication between this and waitForReachable
    +        String waitForWinRmAvailable = setup.get(WAIT_FOR_WINRM_AVAILABLE);
    --- End diff --
    
    Perhaps worth merging the `WAIT_FOR_WINRM_AVAILABLE` and the `WAIT_FOR_SSHABLE`. They
are conceptually the same thing. Would probably have to deprecate the old key, and generalise
the name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message