brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Wed, 20 May 2015 09:08:59 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30682920
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -622,6 +624,14 @@ protected JcloudsSshMachineLocation obtainOnce(ConfigBag setup) throws
NoMachine
                 if (node == null)
                     throw new IllegalStateException("No nodes returned by jclouds create-nodes
in " + setup.getDescription());
     
    +            boolean windows = node.getOperatingSystem().getFamily().equals(OsFamily.WINDOWS);
    +
    +            if (windows) {
    +                // FIXME: Tidy this up and allow for user-specified credentials
    --- End diff --
    
    I'd prefer FIXME/TODO comments to be more specific than "Tidy this up". The second part
of comment is very clear. If there is more tidying than that, then please say what specifically
you're thinking of.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message