brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Tue, 19 May 2015 22:37:54 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30655571
  
    --- Diff: core/src/main/java/brooklyn/util/flags/TypeCoercions.java ---
    @@ -709,6 +710,13 @@ public QuorumCheck apply(final String input) {
                     return QuorumChecks.of(input);
                 }
             });
    +        registerAdapter(ArrayList.class, String[].class, new Function<ArrayList, String[]>()
{
    +            @Nullable
    +            @Override
    +            public String[] apply(@Nullable ArrayList arrayList) {
    +                return (String[]) arrayList.toArray(new String[]{});
    --- End diff --
    
    If marking as `@Nullable`, then should handle that: return null if `arrayList == null`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message