brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Tue, 19 May 2015 16:11:31 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30616169
  
    --- Diff: core/src/main/java/brooklyn/location/basic/WinRmMachineLocation.java ---
    @@ -0,0 +1,266 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.location.basic;
    +
    +import java.io.File;
    +import java.io.FileInputStream;
    +import java.io.FileNotFoundException;
    +import java.io.InputStream;
    +import java.net.InetAddress;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Set;
    +
    +import javax.annotation.Nullable;
    +
    +import org.apache.commons.codec.binary.Base64;
    +import org.python.core.PyException;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import brooklyn.config.ConfigKey;
    +import brooklyn.entity.basic.ConfigKeys;
    +import brooklyn.location.MachineDetails;
    +import brooklyn.location.MachineLocation;
    +import brooklyn.location.OsDetails;
    +import brooklyn.util.exceptions.Exceptions;
    +import brooklyn.util.flags.SetFromFlag;
    +import brooklyn.util.time.Duration;
    +import brooklyn.util.time.Time;
    +import io.cloudsoft.winrm4j.winrm.WinRmTool;
    +import io.cloudsoft.winrm4j.winrm.WinRmToolResponse;
    +
    +import com.google.common.base.Charsets;
    +import com.google.common.base.Joiner;
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.Lists;
    +
    +public class WinRmMachineLocation extends AbstractLocation implements MachineLocation
{
    +
    +    private static final Logger LOG = LoggerFactory.getLogger(WinRmMachineLocation.class);
    +
    +    public static final ConfigKey<String> WINDOWS_USERNAME = ConfigKeys.newStringConfigKey("windows.username",
    +            "Username to use when connecting to the remote machine");
    +
    +    public static final ConfigKey<String> WINDOWS_PASSWORD = ConfigKeys.newStringConfigKey("windows.password",
    +            "Password to use when connecting to the remote machine");
    +
    +    public static final ConfigKey<Integer> COPY_FILE_CHUNK_SIZE_BYTES = ConfigKeys.newIntegerConfigKey("windows.copy.file.size.bytes",
    +            "Size of file chunks (in bytes) to be used when copying a file to the remote
server", 1024);
    +
    +    @SetFromFlag
    --- End diff --
    
    Let's use config keys rather than `@SetFromFlag` anywhere here. The old SetFromFlag approach
in SshMachineLocation should really be refactored.
    
    Same goes for `address` below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message