brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for deployment to Windows
Date Tue, 19 May 2015 16:00:36 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30615039
  
    --- Diff: core/src/main/java/brooklyn/entity/group/DynamicClusterImpl.java ---
    @@ -588,16 +588,22 @@ protected Entity replaceMember(Entity member, Location memberLoc,
Map<?, ?> extr
     
             // choose locations to be deployed to
             List<Location> chosenLocations;
    -        if (isAvailabilityZoneEnabled()) {
    -            List<Location> subLocations = getNonFailedSubLocations();
    -            Multimap<Location, Entity> membersByLocation = getMembersByLocation();
    -            chosenLocations = getZonePlacementStrategy().locationsForAdditions(membersByLocation,
subLocations, delta);
    -            if (chosenLocations.size() != delta) {
    -                throw new IllegalStateException("Node placement strategy chose " + Iterables.size(chosenLocations)
    -                        + ", when expected delta " + delta + " in " + this);
    +        chosenLocations = getMemberSpec() == null ? null : getMemberSpec().getLocations();
    --- End diff --
    
    We need to think about this more. Feels wrong to disable the availability zone behaviour
entirely.
    
    Similarly would prefer us not to merge with `FIXME: Tidy this up!` in the code. That at
least should be fleshed out to a TODO that describes how it could be improved. Or ideally
improve the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message