brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Mon, 18 May 2015 14:50:59 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30514140
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -750,7 +780,36 @@ private String setFromItemIfUnset(String oldValue, Map<?,?>
item, String fieldAt
             return oldValue;
         }
     
    -    
    +    /** scans the given libraries for annotated items, or if null scans the local classpath
*/ 
    --- End diff --
    
    for non-null is does *not* scan the local classpath.  i've refactored to make 3 methods
-- easier to read for sure, but at a cost of more private methods in the class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message