brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Mon, 18 May 2015 12:16:30 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30501884
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -1008,8 +1072,19 @@ private DeploymentPlan makePlanFromYaml(String yaml) {
             return itemDto;
         }
     
    -    private void checkItemNotExists(CatalogItem<?,?> itemDto, boolean forceUpdate)
{
    -        if (!forceUpdate && getCatalogItemDo(itemDto.getSymbolicName(), itemDto.getVersion())
!= null) {
    +    /** returns item DTO if item is an allowed duplicate, null if it should be added,
or false if the item is an allowed duplicate,
    --- End diff --
    
    Comment seems wrong - we don't return false.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message