brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Mon, 18 May 2015 12:10:29 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30501548
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -750,7 +780,36 @@ private String setFromItemIfUnset(String oldValue, Map<?,?>
item, String fieldAt
             return oldValue;
         }
     
    -    
    +    /** scans the given libraries for annotated items, or if null scans the local classpath
*/ 
    +    private Collection<CatalogItemDtoAbstract<?, ?>> scanAnnotations(ManagementContext
mgmt, Collection<CatalogBundle> libraries) {
    +//        CatalogDto dto = CatalogDto.newDefaultLocalScanningDto(CatalogClasspathDo.CatalogScanningModes.ANNOTATIONS);
    --- End diff --
    
    Don't comment out code without a comment to say when and why it would be useful to uncomment
it (or some such).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message