brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Mon, 18 May 2015 11:28:10 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30499409
  
    --- Diff: api/src/main/java/brooklyn/mementos/BrooklynMementoPersister.java ---
    @@ -97,10 +97,13 @@
         /** @deprecated since 0.7.0, use {@link #checkpoint(BrooklynMementoRawData, PersistenceExceptionHandler)}

          * and javadoc on implementations of that */ @Deprecated  // pretty sure this is
not used outwith deprecated code
         void checkpoint(BrooklynMemento memento, PersistenceExceptionHandler exceptionHandler);
    -    
    -    void checkpoint(BrooklynMementoRawData newMemento, PersistenceExceptionHandler exceptionHandler);
     
    +    /** applies a full checkpoint (write) of all state */  
    +    void checkpoint(BrooklynMementoRawData newMemento, PersistenceExceptionHandler exceptionHandler);
    +    /** applies a partial write of state delta */  
         void delta(Delta delta, PersistenceExceptionHandler exceptionHandler);
    +    /** inserts an additional delta to be written on the next delta request */
    +    void queueDelta(Delta delta);
    --- End diff --
    
    We already have the `PeriodicDeltaChangeListener`, which wraps calls to `persister.delta`.
It handles queues, and does smart stuff like if you do a modify then a remove within the same
time period, it will discard the modify and just do the remove.
    
    Should we try to reuse `PeriodicDeltaChangeListener` somehow, rather than having `queueDelta`
here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message