brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Mon, 18 May 2015 10:28:50 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/catalog/internal/ ---
    @@ -0,0 +1,377 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.catalog.internal;
    +import java.util.Collection;
    +import java.util.List;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import brooklyn.catalog.CatalogItem;
    +import brooklyn.config.BrooklynServerConfig;
    +import brooklyn.util.ResourceUtils;
    +import brooklyn.util.collections.MutableList;
    +import brooklyn.util.exceptions.Exceptions;
    +import brooklyn.util.exceptions.FatalRuntimeException;
    +import brooklyn.util.exceptions.RuntimeInterruptedException;
    +import brooklyn.util.flags.TypeCoercions;
    +import brooklyn.util.guava.Maybe;
    +import brooklyn.util.text.Strings;
    +public class CatalogInitialization implements ManagementContextInjectable {
    --- End diff --
    the mutex governs the population of the catalog, to prevent two threads from running this
at the same time.  looks to me that this is functioning correctly.  pure defensive programming
could lock this down further and make everything private but i think that would be overkill
-- the fields and methods are already protected or package private and the class marked `@Beta`
which is to say use caution when extending.  that's the right level of defensiveness for something
which is evolving IMHO.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message