brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-143 - Initial support fo...
Date Thu, 14 May 2015 19:58:38 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/642#discussion_r30356595
  
    --- Diff: sandbox/nosql/src/main/java/brooklyn/entity/nosql/hazelcast/HazelcastNode.java
---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.entity.nosql.hazelcast;
    +
    +import brooklyn.catalog.Catalog;
    +import brooklyn.config.ConfigKey;
    +import brooklyn.entity.basic.ConfigKeys;
    +import brooklyn.entity.basic.SoftwareProcess;
    +import brooklyn.entity.java.UsesJava;
    +import brooklyn.entity.java.UsesJmx;
    +import brooklyn.entity.proxying.ImplementedBy;
    +import brooklyn.event.basic.BasicAttributeSensorAndConfigKey;
    +import brooklyn.event.basic.BasicAttributeSensorAndConfigKey.StringAttributeSensorAndConfigKey;
    +import brooklyn.util.flags.SetFromFlag;
    +import brooklyn.util.javalang.JavaClassNames;
    +
    +/**
    + * An {@link brooklyn.entity.Entity} that represents an Hazelcast node
    + */
    +@Catalog(name="Hazelcast Node", description="Hazelcast is a clustering and highly scalable
data distribution platform for Java.")
    +
    +@ImplementedBy(HazelcastNodeImpl.class)
    +public interface HazelcastNode extends SoftwareProcess, UsesJava, UsesJmx {
    +    @SetFromFlag("version")
    +    ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION,
"3.4.2");
    +    
    +    @SetFromFlag("downloadUrl")
    +    BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new BasicAttributeSensorAndConfigKey<String>(
    +            SoftwareProcess.DOWNLOAD_URL, "https://repo1.maven.org/maven2/com/hazelcast/hazelcast/${version}/hazelcast-${version}.jar");
    +    
    +    @SetFromFlag("configFileUrl")
    +    ConfigKey<String> TEMPLATE_CONFIGURATION_URL = ConfigKeys.newStringConfigKey(
    +            "hazelcast.node.template.configuration.url", "Template file (in freemarker
format) for the hazelcast.xml file", 
    +            JavaClassNames.resolveClasspathUrl(HazelcastNode.class, "hazelcast-brooklyn.xml"));
    +
    +    @SetFromFlag("nodeName")
    +    StringAttributeSensorAndConfigKey NODE_NAME = new StringAttributeSensorAndConfigKey("hazelcast.node.name",

    +            "Node name (or randomly selected if not set", null);
    +    
    +    @SetFromFlag("clusterName")
    +    StringAttributeSensorAndConfigKey CLUSTER_NAME = new StringAttributeSensorAndConfigKey("hazelcast.node.cluster.name",

    +            "Cluster name", null);
    --- End diff --
    
    i don't know enough about hazelcast but is the value of this (cluster name at node) the
same as the value of the `hazelcast.cluster.name` ?  if so we could have the same key name
or use the same constant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message