brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikezaccardo <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add Tomcat 8 Support
Date Tue, 12 May 2015 20:41:34 GMT
Github user mikezaccardo commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/633#issuecomment-101413632
  
    Thanks for looking this over @sjcorbett.  
    
    Yes, the removal of `JasperListener` from `server.xml` is the main change.
    
    I agree about the dubious creation of a `tomcat8` package.  In fact, I originally attempted
to keep them in the same package and made the exact changes to `Tomcat8Server` that you described,
with similarly named new xml files, but deployments failed.  Ultimately I made the new package
and kept the xml files with the same name, which worked.  I will revisit keeping it the same
package because both of our instincts are the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message