brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: CLI commands for manipulating cat...
Date Thu, 07 May 2015 09:46:56 GMT
GitHub user ahgittin reopened a pull request:

    CLI commands for manipulating catalog, and cleaner catalog loading

    approx as discussed on mailing list, except annotations now also supported (easier to
maintain compatibility, in tests)
    for review only at this point; i want to do more testing

You can merge this pull request into a Git repository by running:

    $ git pull catalog-cli

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #617
commit 20810ac9e275eadbf5c00c8b2ba07534841e56f5
Author: Alex Heneveld <>
Date:   2015-04-23T06:46:32Z

    adjust cli start sequence so web/rest is avail always, with isUp check on rest api
    first step towards being able to interactively track the startup sequence and notify on

commit ddce439f17143e838291c8f60ab6b69610ed9249
Author: Alex Heneveld <>
Date:   2015-04-23T10:52:53Z

    add ability to collect startup errors and check healthy through rest api
    changes defaults to be to continue on error, and extends (and optimizes) the BrooklynLauncherTest
which checks this

commit e629602b41613f1068c9fa4b319e99dafc5eeeeb
Author: Alex Heneveld <>
Date:   2015-04-23T15:31:30Z

    javascript checks up on start, shows caution
    popup now appears while server is starting, or if there are errors, and comes back if
server changes to standby.
    changed to plug in *before* the routes are evaluated, so we don't load the wrong data.
    expands rest api to return several pieces of information to simplify gui checks.
    simplifies code in rest filters to block requests not compatible with server state, including
checking for upness there.

commit 65d7ee3c15afda7c5ed4507889fb632f1e2d5c8f
Author: Alex Heneveld <>
Date:   2015-04-27T11:53:09Z

    actually force catalog load by default, and report errors better
    and remove two incompatible items from the catalog, with comments in them - FollowTheSunPolicy
and LoadBalancingPolicy

commit 7d0f1a0efeffd0e16bdca35ec73f0d7ebbd956ed
Author: Alex Heneveld <>
Date:   2015-04-27T13:30:26Z

    show caution dialog if shutting down or if server is unresponsive
    and include shutting down message in rest api.
    tested that i can stop and restart the server and it nicely cycles through sequence of:
    "shutting down", "server unreachable", then "starting up", then restores page.

commit 7556c582ae253a655eb76abba92b75ac811a77b3
Author: Alex Heneveld <>
Date:   2015-05-06T09:48:16Z

    address code review for startup info
    JS masterUri fix, HA check cleanups, removing unneeded classes, and catch catalog error

commit 8bc70bc005cd3f7bc11e36536d31e0166c953603
Author: Alex Heneveld <>
Date:   2015-04-27T13:38:05Z

    introduce CatalogInitialization to cleanly init catalog at the right times
    invoked during persistence cycles, and at startup, holding the new CLI catalog options.
    this does not yet properly initialize things for real-world use, and tests fixed in next

commit 0701b7df68a1c8291cf157fc9fa7c05fa9bac0f8
Author: Alex Heneveld <>
Date:   2015-04-29T12:27:09Z

    yaml catalog supports scanning, experimental, and default
    this restores catalog scanning as the default, based on brooklyn/ in
the cli project;
    there are some limitations on what can be scanned, described in the doc.
    some of the tests configure other catalogs (with core's brooklyn/ used
in many)

commit 4ac8385798adc9e9f11a7e4cd80d155d0dd2f361
Author: Alex Heneveld <>
Date:   2015-04-29T12:32:34Z

    item lister resources put in an appropriate subdir; other related tidies
    code was very ad hoc, but also polluting the root of the all jar; now resources at least
are in a clean subdir

commit 23c31e0e97a5b5980e53e036344efb7773669fe9
Author: Alex Heneveld <>
Date:   2015-04-30T08:13:42Z

    move riak.png to resources file so it ends up in the build

commit c778308d7362fa6ae719afb1aa6d0c7a7922b68c
Author: Alex Heneveld <>
Date:   2015-04-30T10:07:00Z

    tidy CLI options, renaming startup-ignore-error flags; and other tidy
    breaks backwards compatibility in CLI: previously we had `ignoreXxxOnStartup` fields,
but now many of these default to true, and airlift offers no way to make them false, so they
are called `--startupFailOn...` or `--startupContinueOn...`.
    changes the nascent CatalogInitialization so that callbacks get it, and can query settings
such as whether to throw on errors.

commit 718d5e208aef5c282e52a8638031b608233e8f17
Author: Alex Heneveld <>
Date:   2015-05-06T15:37:20Z

    allow access to catalog classloader without populating catalog
    required changes to how catalog is initialized, but i think it's a bit cleaner now (overwriting
other changes in this PR).
    (lots of files touched, unfortunately, but not a lot different here.)

commit 1f5e82d8f439572ab0c6ae52e07e010a61b8e483
Author: Alex Heneveld <>
Date:   2015-05-06T16:49:56Z

    delete catalog items from persistence store on reset

commit 66d9bbc191877461f516698b88817d388c025d80
Author: Alex Heneveld <>
Date:   2015-05-06T22:02:03Z

    allow "addition" of a catalog item which already exists if it's exactly the same
    adds equals and hashCode to CatlogItemDto and CatalogBundleDto

commit 302dc98a5468ed29352fbeb8d1c325435095909c
Author: Alex Heneveld <>
Date:   2015-05-06T14:00:39Z

    install a, and update docs
    and tweak poms to exclude license since these are config files the user is meant to edit;
    remove the old catalog.xml, including mentions in the docs


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message