brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertgmoss <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add initial support for PaaS loca...
Date Wed, 06 May 2015 12:24:45 GMT
Github user robertgmoss commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/629#discussion_r29752708
  
    --- Diff: core/src/test/java/brooklyn/entity/drivers/ReflectiveEntityDriverFactoryTest.java
---
    @@ -54,12 +58,22 @@ protected void assertDriverIs(Class<?> clazz) {
             assertTrue(driver.getClass().equals(clazz), "driver="+driver+"; should be "+clazz);
         }
         
    +    protected void assertDriverIs(Class<?> clazz, Location location) {
    --- End diff --
    
    why not eliminate duplicate code and use this method for the existing test, too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message