brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Startup info
Date Wed, 06 May 2015 08:41:39 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/614#discussion_r29742349
  
    --- Diff: usage/rest-server/src/test/java/brooklyn/rest/HaHotCheckTest.java ---
    @@ -43,75 +43,61 @@
     
     public class HaHotCheckTest extends BrooklynRestResourceTest {
     
    -    private ManagementContextMock mgmtMock;
    -
    -    @Override
    -    @BeforeClass(alwaysRun = true)
    -    public void setUp() throws Exception {
    -        mgmtMock = new ManagementContextMock();
    -        super.setUp();
    -    }
    -
    -    @Override
    -    @AfterClass(alwaysRun = true)
    -    public void tearDown() throws Exception {
    -        super.tearDown();
    -    }
    -
         @BeforeMethod(alwaysRun = true)
    -    public void setUpMethod() {
    -        mgmtMock.setState(ManagementNodeState.MASTER);
    -    }
    +    public void setUp() throws Exception { super.setUp(); }
     
    +    @AfterMethod(alwaysRun = false)
    +    public void tearDown() throws Exception { super.tearDown(); }
    --- End diff --
    
    superclass methods are `@BeforeClass` not `@BeforeMethod` (and same with after).
    
    not sure why `@After...` was `alwaysRun=false` however.  i'm experimenting with changing
that to `true`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message