Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-589-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-589-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: make ConfigBag thread-safe
Content-Type: text/plain
Message-Id: <20150413010701.71FBBE031B@git1-us-west.apache.org>
Date: Mon, 13 Apr 2015 01:07:01 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/589#discussion_r28209984
  
    --- Diff: core/src/main/java/brooklyn/util/config/ConfigBag.java ---
    @@ -96,14 +102,42 @@ public static ConfigBag newInstanceCopying(final ConfigBag configBag) {
          * (note: this applies even for values which are overridden and the overridden value is used);
          * however subsequent uses in the original set will not be marked here
          */
    -    public static ConfigBag newInstanceExtending(final ConfigBag configBag, Map<?,?> flags) {
    +    @Beta
    +    public static ConfigBag newInstanceExtending(final ConfigBag parentBag) {
    +        return new ConfigBagExtendingParent(parentBag).copy(parentBag);
    +    }
    +
    +    /** @see #newInstanceExtending(ConfigBag) */
    +    public static class ConfigBagExtendingParent extends ConfigBag {
    +        ConfigBag parentBag;
    +        private ConfigBagExtendingParent(ConfigBag parentBag) {
    +            this.parentBag = parentBag;
    --- End diff --
    
    and do in constructor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---