brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Don't retry jclouds requests on e...
Date Thu, 30 Apr 2015 15:50:39 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/620

    Don't retry jclouds requests on exception if unsafe request method

    The request could already been processed on the server when the exception occurs, retry
only for request methods without side effects.
    
    Any ideas how this could be tested?
    
    Make sense to use the change for all providers, though the problem has been observed on
Softlayer specifically: `Read timed out connecting to POST https://api.softlayer.com/rest/v3/SoftLayer_Virtual_Guest`.
Because of the retries a machine has been provisioned 6 times.
    
    @andreaturli do you think this should be filed as a bug report/patch in jclouds?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn safe-retry

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #620
    
----
commit 987ec7ee51acb540e7f13c02bd15d42cc4552de0
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2015-04-30T15:44:39Z

    Don't retry jclouds requests on exception if unsafe request method
    
    The request could already be be processed on the server when the exception occurs, retry
only for request methods without side effects.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message